Skip to content

record ms precision in timestamps #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2prateek merged 1 commit into from
Feb 15, 2017
Merged

record ms precision in timestamps #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions analytics-tests/src/test/java/com/segment/analytics/BatchPayloadWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,12 @@ public class BatchPayloadWriterTest {
.endObject()
.close();

// todo: inject a fake clock. for now we'll compare a lower precision.
String date = toISO8601Date(new Date());
String expectedDate = date.substring(0, date.length() - 8);

assertThat(byteArrayOutputStream.toString()) //
.isEqualTo("{\"batch\":[qaz],\"sentAt\":\"" + toISO8601Date(new Date()) + "\"}")
.overridingErrorMessage("its ok if this failed close to midnight!");
.contains("{\"batch\":[qaz],\"sentAt\":\"" + expectedDate);
}

@Test public void batchPayloadWriterFailsForNoItem() throws IOException {
Expand Down
2 changes: 1 addition & 1 deletion analytics/src/main/java/com/segment/analytics/internal/Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ public final class Utils {
private static final ThreadLocal<DateFormat> ISO_8601_DATE_FORMAT =
new ThreadLocal<DateFormat>() {
@Override protected DateFormat initialValue() {
return new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ssZ", Locale.US);
return new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ", Locale.US);
}
};

Expand Down