Fix calling to getInputStream on errors#537
Merged
f2prateek merged 1 commit intosegmentio:masterfrom Oct 23, 2017
yoavst:bug-fix-error-handling
Merged
Fix calling to getInputStream on errors#537f2prateek merged 1 commit intosegmentio:masterfrom yoavst:bug-fix-error-handling
f2prateek merged 1 commit intosegmentio:masterfrom
yoavst:bug-fix-error-handling
Conversation
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
==========================================
+ Coverage 83.22% 83.24% +0.02%
==========================================
Files 30 30
Lines 2438 2441 +3
Branches 277 277
==========================================
+ Hits 2029 2032 +3
Misses 326 326
Partials 83 83
Continue to review full report at Codecov.
|
Contributor
|
Is this documented anywhere? |
Contributor
Author
f2prateek
approved these changes
Oct 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the status code is above 300 (Don't know for sure if for all codes, but for some of them for sure),
getInputStream()throwsFileNotFoundExceptionand the stream is ingetErrorStream().