Skip to content

Rename getter "putSubtotal()" to "subtotal()"#547

Merged
f2prateek merged 2 commits intosegmentio:masterfrom
egor-n:patch-1
Oct 25, 2017
Merged

Rename getter "putSubtotal()" to "subtotal()"#547
f2prateek merged 2 commits intosegmentio:masterfrom
egor-n:patch-1

Conversation

@egor-n
Copy link
Copy Markdown
Contributor

@egor-n egor-n commented Oct 24, 2017

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 24, 2017

Codecov Report

Merging #547 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
- Coverage   83.24%   83.21%   -0.04%     
==========================================
  Files          30       30              
  Lines        2441     2442       +1     
  Branches      277      277              
==========================================
  Hits         2032     2032              
- Misses        326      327       +1     
  Partials       83       83
Impacted Files Coverage Δ
...rc/main/java/com/segment/analytics/Properties.java 92.3% <0%> (-1.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f96759...54c5fdd. Read the comment docs.

@f2prateek
Copy link
Copy Markdown
Contributor

Thanks! Could you leave the old method in and mark it as deprecated? Don't want to accidentally break API for folks that might be using this - we can remove the deprecated one in a couple of months

@f2prateek f2prateek merged commit 110a11c into segmentio:master Oct 25, 2017
@f2prateek
Copy link
Copy Markdown
Contributor

Thanks!

@egor-n egor-n deleted the patch-1 branch October 25, 2017 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants