Rename getter "putSubtotal()" to "subtotal()"#547
Merged
f2prateek merged 2 commits intosegmentio:masterfrom Oct 25, 2017
egor-n:patch-1
Merged
Rename getter "putSubtotal()" to "subtotal()"#547f2prateek merged 2 commits intosegmentio:masterfrom egor-n:patch-1
f2prateek merged 2 commits intosegmentio:masterfrom
egor-n:patch-1
Conversation
Codecov Report
@@ Coverage Diff @@
## master #547 +/- ##
==========================================
- Coverage 83.24% 83.21% -0.04%
==========================================
Files 30 30
Lines 2441 2442 +1
Branches 277 277
==========================================
Hits 2032 2032
- Misses 326 327 +1
Partials 83 83
Continue to review full report at Codecov.
|
Contributor
|
Thanks! Could you leave the old method in and mark it as deprecated? Don't want to accidentally break API for folks that might be using this - we can remove the deprecated one in a couple of months |
f2prateek
approved these changes
Oct 25, 2017
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.