Skip to content

Support schema defaults for new events.#552

Merged
f2prateek merged 1 commit intomasterfrom
default-events
Nov 6, 2017
Merged

Support schema defaults for new events.#552
f2prateek merged 1 commit intomasterfrom
default-events

Conversation

@f2prateek
Copy link
Copy Markdown
Contributor

If an event is not present in the tracking plan, we'll now lookup the schema defaults for the project.

If the event is disabled in the schema default, it will only be sent to the Segment integration (i.e. api.segment.io).

If the event is enabled in the schema default, it will be sent to all integrations.

Ref: https://paper.dropbox.com/doc/Schema-Client-Side-Defaults-DufdS8Ej43mnFXvvMqm1b

@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 6, 2017

Codecov Report

Merging #552 into master will increase coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   83.22%   83.24%   +0.02%     
==========================================
  Files          30       30              
  Lines        2444     2453       +9     
  Branches      278      281       +3     
==========================================
+ Hits         2034     2042       +8     
- Misses        327      328       +1     
  Partials       83       83
Impacted Files Coverage Δ
...va/com/segment/analytics/IntegrationOperation.java 89.52% <80%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2ee96...9cf5714. Read the comment docs.

Copy link
Copy Markdown

@danielstjules danielstjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

If an event is not present in the tracking plan, we'll now lookup the schema defaults for the project.

If the event is disabled in the schema default, it will only be sent to the Segment integration (i.e. api.segment.io).

If the event is enabled in the schema default, it will be sent to all integrations.

Ref: https://paper.dropbox.com/doc/Schema-Client-Side-Defaults-DufdS8Ej43mnFXvvMqm1b
@f2prateek
Copy link
Copy Markdown
Contributor Author

Made some test updates to get better coverage.

@f2prateek f2prateek merged commit c6ba3e0 into master Nov 6, 2017
@f2prateek f2prateek deleted the default-events branch November 6, 2017 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants