Skip to content

[DEST-1532] Track "Deep Link Opened" on activity creation#637

Merged
bsneed merged 3 commits intomasterfrom
dest-1532
Dec 16, 2019
Merged

[DEST-1532] Track "Deep Link Opened" on activity creation#637
bsneed merged 3 commits intomasterfrom
dest-1532

Conversation

@CarlosMecha
Copy link
Copy Markdown
Contributor

It sends a track call with the following data as properties:

  • url: Url from the deep link
  • param...: Url Query param.

The main goal is to send the campaign information from the URL to Segment and destinations like Google Analytics 360.

DEST-1532.

@CarlosMecha CarlosMecha requested a review from bsneed December 7, 2019 00:22
@bsneed
Copy link
Copy Markdown
Contributor

bsneed commented Dec 13, 2019

@CarlosMecha need to run gradlew spotlessApply on your end and push the changes so tests will pass.

@CarlosMecha
Copy link
Copy Markdown
Contributor Author

Hey @bsneed , I can't run that command, it can't parse my java version. The error is: FAILURE: Could not determine java version from 11.0.5

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #637 into master will decrease coverage by 0.05%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   83.33%   83.27%   -0.06%     
==========================================
  Files          31       31              
  Lines        2520     2541      +21     
  Branches      293      297       +4     
==========================================
+ Hits         2100     2116      +16     
- Misses        331      334       +3     
- Partials       89       91       +2
Impacted Files Coverage Δ
...src/main/java/com/segment/analytics/Analytics.java 74.82% <50%> (-0.18%) ⬇️
...analytics/AnalyticsActivityLifecycleCallbacks.java 85.71% <82.35%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f890a...6e4b533. Read the comment docs.

@bsneed bsneed merged commit 01d26bf into master Dec 16, 2019
@bsneed bsneed deleted the dest-1532 branch December 16, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants