refactor: Remove unnecessary import of netinet6/in6.h#1071
Closed
thedeveloperr wants to merge 1 commit intosegmentio:masterfrom
Closed
refactor: Remove unnecessary import of netinet6/in6.h#1071thedeveloperr wants to merge 1 commit intosegmentio:masterfrom
thedeveloperr wants to merge 1 commit intosegmentio:masterfrom
Conversation
Removed import for netinet6/in6.h as it's no longer needed. netinet/in.h already transitively includes netinet6/in6.h This fixes build error with xcode sdk 26.4 Same thing done by apache/cordova-plugin-network-information#166
Author
|
Oh looks like duplicate of #1070 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed import for netinet6/in6.h as it's no longer needed. netinet/in.h already transitively includes netinet6/in6.h This fixes build error with xcode sdk 26.4
Same thing done by apache/cordova-plugin-network-information#166
Where should the reviewer start?
Segment/Classes/SEGReachability.m
How should this be manually tested?
Any background context you want to provide?
I used AI and existing github issues to arrive at this solution. So an expert review would be appreciated.
What are the relevant tickets?
Screenshots or screencasts (if UI/UX change)
Questions: