Fix file descriptor leak in EventPipeline #284
Merged
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed from .let to .use to ensure InputStream is always closed, preventing FD exhaustion when exceptions occur during upload
Contributor
Author
|
Hi @wenxi-zeng |
wenxi-zeng
approved these changes
Dec 16, 2025
Contributor
wenxi-zeng
left a comment
wenxi-zeng
left a comment
There was a problem hiding this comment.
neat! thanks for contributing! will get it merged and make a release soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from
.letto.useto ensureInputStreamis always closed, preventing FD exhaustion when exceptions occur during upload.This results in serious problems when environments are unable to connect to the Segment API over an extended duration