Skip to content

fix(core): fix kotlin gradle version for integrations#109

Merged
bsneed merged 1 commit intomasterfrom
bsneed/kotlin-fix
Sep 23, 2019
Merged

fix(core): fix kotlin gradle version for integrations#109
bsneed merged 1 commit intomasterfrom
bsneed/kotlin-fix

Conversation

@bsneed
Copy link
Copy Markdown
Contributor

@bsneed bsneed commented Sep 23, 2019

@bsneed bsneed requested a review from fathyb September 23, 2019 19:43
Copy link
Copy Markdown
Contributor

@fathyb fathyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nitpicks:

  • Any reason to use 1.3.21 instead of 1.3.50?
  • Could you add which issues this fixes in the PR description and make sure it is in the commit description when merged? This will ensure the changelog is properly generated

@fathyb
Copy link
Copy Markdown
Contributor

fathyb commented Sep 23, 2019

Nevermind for the version! Just noticed we're already using 1.3.21 in the main module:

classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.3.21'

@bsneed bsneed merged commit 3f4e3cc into master Sep 23, 2019
@oscb oscb deleted the bsneed/kotlin-fix branch February 23, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants