Merged
Conversation
kadikraman
force-pushed
the
bugfix/fix-android-detox
branch
from
79677d6 to
dd9cef7
Compare
kadikraman
changed the title
kadikraman
force-pushed
the
bugfix/fix-android-detox
branch
from
dd9cef7 to
7144474
Compare
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 86.09% 86.09%
=======================================
Files 7 7
Lines 151 151
Branches 28 21 -7
=======================================
Hits 130 130
Misses 20 20
Partials 1 1Continue to review full report at Codecov.
|
f2prateek
approved these changes
Jun 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end to end tests for detox aren't actually being run during the
test-androidstep, just the detox app is built.The build fails with the following error, because yarn cannot find the detox binary:
This adds the detox command to
package.jsonin the test app.