fix: rename em-dash asset filenames to ASCII hyphens#433
Merged
didiergarcia merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
The asset files and paths under Examples/apps/SegmentExtensionsExample/Assets.xcassets used em-dash (U+2014, "—") characters in their names. GitHub's auto-generated source archive (https://github.com/segmentio/analytics-swift/archive/refs/tags/<tag>.zip) encodes these as UTF-8, but the default macOS unzip (Info-ZIP) cannot decode them and aborts with "checkdir error: ... Illegal byte sequence". This in turn breaks Xcode Swift Package Manager resolution for any consumer whose environment extracts the archive with that unzip. Rename the two imagesets and their PNGs to use ASCII hyphens ("-"), and update the Contents.json filename keys plus the four Main.storyboard image references that name them. Fixes #431
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 73.84% 73.17% -0.68%
==========================================
Files 54 54
Lines 5425 4063 -1362
==========================================
- Hits 4006 2973 -1033
+ Misses 1419 1090 -329 🚀 New features to boost your workflow:
|
bsneed
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Examples/apps/SegmentExtensionsExample/Assets.xcassets/to drop em-dash (U+2014,—) characters in favor of ASCII hyphens (-).filenamekeys in bothContents.jsonfiles and the 4image="..."/<image name="..."/>references inMain.storyboardthat named them.Why
GitHub's auto-generated source archive for each tag encodes the em-dashes as UTF-8 in ZIP entries. The default macOS
unzip(Info-ZIP) can't decode those entries and aborts with:The same extraction path is used by Xcode when resolving this package via SPM from a tag/archive, so downstream consumers see an
"unzipping failed"error and can't install the package.Repro (on stock macOS, before this fix):
Fixes #431.
Scope
git mvso history is preserved.Contents.json, 4 inMain.storyboard.grep -rn $'—' .andfind . -name '*—*'are both empty after this change).project.pbxprojis untouched — it referencesAssets.xcassetsas a folder, not individual imagesets.Package.swift, no SDK behavior changes.Test plan
Examples/apps/SegmentExtensionsExample/SegmentExtensionsExample.xcworkspacein Xcode, build + run on iOS Simulator, confirm both images still render (Twilio/Segment horizontal logo on splash, avatar on the main view).curl -L https://github.com/segmentio/analytics-swift/archive/refs/tags/<next>.zip -o test.zip && unzip test.zipcompletes cleanly with noIllegal byte sequence."unzipping failed"error.