Skip to content
This repository was archived by the owner on Sep 3, 2022. It is now read-only.

Conversation

@danieljackins
Copy link
Contributor

@danieljackins danieljackins commented Feb 24, 2020

https://segment.atlassian.net/browse/LIB-1632

This PR updates HISTORY.md to include changes that weren't included in the history. It also adds libraries-team as a codeowner to the repo, and updates RELEASING.md to make sure we're properly updating the history when we do a release.

@danieljackins danieljackins changed the title update history, add CODEOWNERS file Fix and improve release process Feb 24, 2020
@ndhoule
Copy link
Contributor

ndhoule commented Feb 24, 2020

Codecov Report

Merging #133 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          12       12           
  Lines         758      758           
=======================================
  Hits          741      741           
  Misses         17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ff1a2...259a07b. Read the comment docs.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@61ff1a2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #133   +/-   ##
=========================================
  Coverage          ?   97.75%           
=========================================
  Files             ?       12           
  Lines             ?      758           
  Branches          ?        0           
=========================================
  Hits              ?      741           
  Misses            ?       17           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61ff1a2...e434971. Read the comment docs.

Copy link

@bsneed bsneed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE IT!!!

@danieljackins danieljackins changed the title Fix and improve release process (readme) Fix and improve release process Feb 25, 2020
@danieljackins danieljackins merged commit fcbadef into master Feb 25, 2020
@pooyaj pooyaj deleted the dj/release-fix branch July 20, 2020 19:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants