[LIB-1619] Fix Wootric initialization #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fathyb
commented
Mar 3, 2020
fathyb
commented
Mar 31, 2020
| analytics.assert(window.wootricSettings.properties.property2 === 'bar'); | ||
| }); | ||
|
|
||
| it('should set suffix _date to property key and convert date if trait is a date', function() { |
Contributor
Author
There was a problem hiding this comment.
This test didn't work before and is only failing now because we only test commit changes. We can verify this by running:
git checkout origin/master
git clean -fdx
yarn
yarn workspace @segment/analytics.js-integration-wootric run test
dk1027
approved these changes
Apr 1, 2020
bsneed
approved these changes
Apr 1, 2020
marinhero
pushed a commit
to Wootric/analytics.js-integrations-1
that referenced
this pull request
Apr 24, 2020
* fix(wootric): update analytics.js-integration * Prevent failure when changing yarn.lock * Revert CircleCI changes * Revert yarn.lock changes * Skip failling test * Upgrade to ajs-integration@latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Wootric to use
@segment/analytics.js-integration@3.3.1to fix initialization issues.Testing completed successfully on local and staging.
Are there breaking changes in this PR?
No.
Any background context you want to provide?
https://segment.atlassian.net/browse/LIB-1619
Is there parity with the server-side/android/iOS integration components (if applicable)?
No.
Does this require a new integration setting? If so, please explain how the new setting works
No.
Links to helpful docs and other external resources
N/A