Adobe Analytics: Combine all inflight changes + Implement video playback interrupted #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 1, 2020 18:03
commit 4ac7ccb Author: Brie <brienne.mcnally@segment.com> Date: Tue Apr 28 12:06:41 2020 -0700 Remove ternary commit 79c8142 Merge: e331eb2 3bcebe0 Author: Brie McNally <31782219+briemcnally@users.noreply.github.com> Date: Thu Apr 23 16:31:22 2020 -0700 Merge branch 'master' into brie/aa-merch-events commit e331eb2 Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 23 16:19:07 2020 -0700 Bump release candidate commit 676cfda Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 23 16:16:53 2020 -0700 Add unit tests commit 3452451 Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 23 16:15:51 2020 -0700 Add in else statement on map function commit 6ae3c91 Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 23 15:58:56 2020 -0700 Update to ensure that can pass empty event string commit 4e967c7 Merge: 3d61d27 0a00eec Author: Brie McNally <31782219+briemcnally@users.noreply.github.com> Date: Mon Apr 20 16:52:54 2020 -0700 Merge branch 'master' into brie/aa-merch-events commit 3d61d27 Author: Brie <brienne.mcnally@segment.com> Date: Mon Apr 20 16:47:49 2020 -0700 Update to release candidate version commit cf06ab5 Author: Brie <brienne.mcnally@segment.com> Date: Mon Apr 20 16:41:41 2020 -0700 Update scripts commit dc76ffb Merge: 6c719c4 9d4d604 Author: Brie <brienne.mcnally@segment.com> Date: Wed Apr 15 09:52:54 2020 -0700 Merge branch 'brie/aa-merch-events' of ssh://github.com/segmentio/analytics.js-integrations into brie/aa-merch-events commit 6c719c4 Author: Brie <brienne.mcnally@segment.com> Date: Wed Apr 15 09:52:15 2020 -0700 Update History.md commit 3dab0e2 Merge: 7be8df7 b72a91c Author: Brie <brienne.mcnally@segment.com> Date: Tue Apr 14 15:42:06 2020 -0700 Merge branch 'gps/aa-2.20' into brie/aa-merch-events commit 9d4d604 Merge: 7be8df7 8c4c227 Author: Brie McNally <31782219+briemcnally@users.noreply.github.com> Date: Tue Apr 14 10:50:23 2020 -0700 Merge branch 'master' into brie/aa-merch-events commit 7be8df7 Author: Brie <brienne.mcnally@segment.com> Date: Mon Apr 13 13:05:49 2020 -0700 Update comments and move function commit 97e4e45 Author: Brie <brienne.mcnally@segment.com> Date: Fri Apr 10 15:40:42 2020 -0700 Add unit tests commit 077e8e5 Author: Brie <brienne.mcnally@segment.com> Date: Fri Apr 10 15:40:06 2020 -0700 Add merchEvent support initial commit commit b72a91c Author: Gabriel P Samson <gabriel.samson@segment.com> Date: Mon Apr 6 15:09:02 2020 -0700 AA: Remove .only from tests commit 8138783 Author: Gabriel P Samson <gabriel.samson@segment.com> Date: Mon Apr 6 14:28:48 2020 -0700 AA: Update domain to prod commit 3e69ffb Author: Gabriel P Samson <gabriel.samson@segment.com> Date: Mon Apr 6 12:56:44 2020 -0700 AA: Bump npm version commit 33f5f6f Author: Gabriel P Samson <gabriel.samson@segment.com> Date: Mon Apr 6 12:47:55 2020 -0700 AA: Bump SDKs to latest (stage)
commit 8e5ddcc Author: Brie <brienne.mcnally@segment.com> Date: Fri May 1 10:37:58 2020 -0700 Update package.json and HISTORY.md commit 08023ea Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 30 19:09:46 2020 -0700 Updatet JS doc commit 35161df Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 30 19:03:04 2020 -0700 Update unit test for edge case for name spacing commit cb6bb79 Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 30 19:02:33 2020 -0700 Fix bug where key/values for context data different name spacing commit 2c34180 Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 30 15:16:10 2020 -0700 Add unit tests for page calls commit bf80537 Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 30 15:04:51 2020 -0700 Add unit test for track commit ad7f31f Author: Brie <brienne.mcnally@segment.com> Date: Thu Apr 30 15:04:17 2020 -0700 Add support for top level property mappings
briemcnally
approved these changes
May 2, 2020
briemcnally
reviewed
May 2, 2020
Contributor
|
LGTM. Just left one comment about the package version. |
briemcnally
reviewed
May 4, 2020
Contributor
|
@gpsamson added debug flag set to true per AA docs: https://docs.adobe.com/content/help/en/media-analytics/using/sdk-implement/validation/debugging/sdk-debugging.html. Will cut new releasee candidate and pin Fox. |
Contributor
|
Last commit just removed my changes to set debug to true. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merges [STRATCONN-27] Adobe Analytics Merch Events #456 and [STRATCONN-144] Ability to map top level fields to Adobe #465
Implements an event handler for
Video Playback Interruptedwhich calls the media SDK'strackPause()method.All changes have been tested in stage and locally via compiler.
Changes have been validated by UAT by Fox and Levis.
Testing completed successfully against several customer staging accounts. Please see the respective PRs this merges.
Are there breaking changes in this PR?
N/a
Any background context you want to provide?
Please see PRs that are being merged into this master PR.
Is there parity with the server-side/android/iOS integration components (if applicable)?
N/A
Does this require a new integration setting? If so, please explain how the new setting works
No
Links to helpful docs and other external resources