-
Notifications
You must be signed in to change notification settings - Fork 140
[STRATCONN-272, STRATCONN-265] Update trackComplete, Stringify context data, Support window-based playhead #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Stringify context vals of type bool * Add tests * LINT
…onn-272-update-trackcomplete
|
Merged in #473 since only one version can be pinned to a source at a time. |
|
@gpsamson I just pulled this and tested with compiler.I passed |
|
@briemcnally. That's odd. An event with My context settings has The same is also true when the value is set to |
|
🤔 Wonder why it didn't work for me. I'll try it again later. |
https://segment.atlassian.net/browse/CC-6682
What does this PR do?
falseboolean values when setting them on the window object. This does not break existing behavior since booleans are stringified when they're sent in the query string.Note: It does not seem like we pause the playhead ever in the a.js integration so I did not add this to Video Playback Completed.
Are there breaking changes in this PR?
No.
Is there parity with the server-side/android/iOS integration components (if applicable)?
iOS and a.js integrations are being updated with the same changes.
Does this require a new integration setting? If so, please explain how the new setting works
No.
Links to helpful docs and other external resources
Adobe docs
Core playback on Android: https://docs.adobe.com/content/help/en/media-analytics/using/sdk-implement/track-av-playback/track-core/track-core-javascript/track-core-js3.html
Chapters on Android: https://docs.adobe.com/content/help/en/media-analytics/using/sdk-implement/track-chapters/track-chapters-js/track-chapters-js3.html