Gps/aa bools #489
Merged
Gps/aa bools #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 26, 2020 13:27
gpsamson
added a commit
that referenced
this pull request
Jul 13, 2020
…t data, Support window-based playhead (#484) * Add event names to top level property list * Update unit tests * Update HISTORY.md and package.json * AA: Add window based playheads * Bump AA version * [STRATCONN-272] update trackComplete logic on video events * Update tests * Gps/aa bools (#489) * Stringify context vals of type bool * Add tests * LINT * Stringify bools in createCustomVideoMetadataContext * Fix setter in createCustomVideoMetadataContext * Update HISTORY.md Co-authored-by: Brie <brienne.mcnally@segment.com> Co-authored-by: Gabriel P Samson <gabriel.samson@segment.com> Co-authored-by: Kiara Daswani <kiara.daswani@Kiaras-MBP.lan> Co-authored-by: Gabriel Samson <gpsamson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Are there breaking changes in this PR?
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources