Add forms SDK to Hubspot integration #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccnixon
force-pushed
the
hubspot/add-forms-sdk
branch
5 times, most recently
from
f2cbfb1 to
d2bb314
Compare
ccnixon
force-pushed
the
hubspot/add-forms-sdk
branch
from
d2bb314 to
8ea4680
Compare
CarlosMecha
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support to optionally load the Hubspot Forms SDK alongside their analytics pixel: https://developers.hubspot.com/docs/methods/forms/advanced_form_options.
Are there breaking changes in this PR?
No
Has this been tested end-to-end? Please provide screenshots on how the fix now populates in the end tool. If not, what was done to test?
Any background context you want to provide?
This is a customer request.
Is there parity with the server-side/android/iOS integration (if applicable)?
Does this require a metadata change? If so, please link the PR from https://github.com/segmentio/destination-scripts.
What are the relevant tickets?
https://segment.atlassian.net/browse/PLATFORM-1464
Link to CC ticket
https://segment.atlassian.net/browse/CC-1407
List all the tests accounts you have used to make sure this change works
Helpful Docs