[FB Pixel] Add support for preset data processing options #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennan
approved these changes
Jul 20, 2020
Contributor
Author
|
Hey @brennan - just re-requesting your review as we tweaked one line. Instead of reading from the |
brennan
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates FB Pixel's data processing logic to look for preset options on the window object. If valid parameters are set on
window.fbDataProcessingOptionswe'll pass those to the Pixel SDK. If the parameters set on the window objects are undefined or invalid then we'll fallback to these default options:['LDU'], 0, 0.For more information on valid values see: https://developers.facebook.com/docs/marketing-apis/data-processing-options#reference
Are there breaking changes in this PR?
Nah
Any background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
server-side and iOS will be updated to support preset options
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources
Test Plan
Rollback Procedure