Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions integrations/facebook-pixel/HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
2.11.1/ 2020-07-22
==================

* Add support to override the Data Processing Options by pass them in the load options object.
```
analytics.load("<writeKey>", {
integrations: {
'Facebook Pixel': {
dataProcessingOptions: [['LDU'], 1, 1000]
}
}
});
```

2.11.0/ 2020-07-16
==================

Expand Down
27 changes: 26 additions & 1 deletion integrations/facebook-pixel/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,9 @@ FacebookPixel.prototype.initialize = function() {
window.fbq('set', 'autoConfig', false, this.options.pixelId);
}
if (this.options.limitedDataUse) {
window.fbq('dataProcessingOptions', ['LDU'], 0, 0);
this.validateAndSetDataProcessing(
this.options.dataProcessingOptions || [['LDU'], 0, 0]
);
}
if (this.options.initWithExistingTraits) {
var traits = this.formatTraits(this.analytics);
Expand Down Expand Up @@ -718,6 +720,29 @@ FacebookPixel.prototype.buildPayload = function(track, isStandardEvent) {
return payload;
};

/**
* Validates that a set of parameters are formatted correctly and passes them to the pixel instance.
* https://developers.facebook.com/docs/marketing-apis/data-processing-options#reference
*
* @param {Array} options
*
* @api private
*/
FacebookPixel.prototype.validateAndSetDataProcessing = function(params) {
var lenOk = params.length === 3;
var valOk =
Array.isArray(params[0]) &&
typeof params[1] === 'number' &&
typeof params[2] === 'number';

// Pass the data processing options if they're valid, otherwise, fallback to geolocation.
if (lenOk && valOk) {
window.fbq('dataProcessingOptions', params[0], params[1], params[2]);
} else {
window.fbq('dataProcessingOptions', ['LDU'], 0, 0);
}
};

/**
* Merge two javascript objects. This works similarly to `Object.assign({}, obj1, obj2)`
* but it's compatible with old browsers. The properties of the first argument takes preference
Expand Down
2 changes: 1 addition & 1 deletion integrations/facebook-pixel/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@segment/analytics.js-integration-facebook-pixel",
"description": "The Facebook Pixel analytics.js integration.",
"version": "2.11.0",
"version": "2.11.1",
"keywords": [
"analytics.js",
"analytics.js-integration",
Expand Down
32 changes: 32 additions & 0 deletions integrations/facebook-pixel/test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,38 @@ describe('Facebook Pixel', function() {
);
});
});

describe('#initialize with preset data processing options', function() {
before(function() {
options.dataProcessingOptions = [['LDU'], 99, 99];
});

after(function() {
delete options.dataProcessingOptions;
});

it('should call dataProcessingOptions with the preset values', function() {
analytics.stub(window, 'fbq');
analytics.initialize();
analytics.called(window.fbq, 'dataProcessingOptions', ['LDU'], 99, 99);
});
});

describe('#initialize with fallback data processing options', function() {
before(function() {
options.dataProcessingOptions = ['a string', true, 99];
});

after(function() {
delete options.dataProcessingOptions;
});

it('should call dataProcessingOptions with fallback values', function() {
analytics.stub(window, 'fbq');
analytics.initialize();
analytics.called(window.fbq, 'dataProcessingOptions', ['LDU'], 0, 0);
});
});
});

describe('loading', function() {
Expand Down