Skip to content

feat(optimizely): Expose Edge API to track Edge experiments #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

feat(optimizely): Expose Edge API to track Edge experiments #515

wants to merge 21 commits into from

Conversation

@brennan
Copy link
Contributor

@brennan brennan commented Sep 21, 2020 •
edited
Loading

What does this PR do?

  • This PR imports updates from an Optimizely-submitted PR here.
  • Wraps all push calls with a conditional, which if window.optimizelyEdge (the edge API) exists on a page, it'll push to window.optimizelyEdge instead of window.optimizely.
  • For now, we'll only roll this change out to specific customers.

Are there breaking changes in this PR?

  • No, we still track and push to window.optimizely in Web.

Any background context you want to provide?

  • Allows Performance Edge customers to track Performance Edge experiments now.

Is there parity with the server-side/android/iOS integration components (if applicable)?

  • N/A

Does this require a new integration setting? If so, please explain how the new setting works

  • N/A

nchilada and others added 21 commits June 12, 2020 16:40
@nchilada
refactor: Clean up the Optimizely integration
e1fa89f 
* Don't attempt to interface with Optimizely Classic Web, since Classic is finally dead
* Prepare to support Optimizely Edge, an alternative to Optimizely Web
* Drop all references to customCampaignProperties. It seems to have been documented [here](https://segment.com/docs/connections/destinations/catalog/optimizely-web/#settings) but it couldn't possibly have worked.
* Generally refactor the code and tests.
@nchilada
Way more changes
8e556d5
@nchilada
Finish fixing and refactoring tests
e5475be
@nchilada
yarn add lodash --dev
099f98b
@nchilada
Update HISTORY.md
ed636c0
@nchilada
Fix lint
d2211d7
@patrickshih-optimizely
edge implementation
baf7222
@patrickshih-optimizely
fix unit tests
38e6f7d
@patrickshih-optimizely
some clean up
394547a
@patrickshih-optimizely
final cleanup
0744884
@patrickshih-optimizely
cr
ac7995b
@brennan
Merge branch 'master' into brennan/patrickshih/rebased-with-edge
9ee3d06
@patrickshih-optimizely
changing of unit tests part 1
6bfeef1
@patrickshih-optimizely
unit tests pt 2, referrer for edge
e30113c
@patrickshih-optimizely
clean up
5dd667b
@brennan
Merge branch 'patrickshih/rebased-with-edge' into brennan/patrickshih…
cfc0aad 
…/rebased-with-edge
@patrickshih-optimizely
revert yarn.lock
1da50a8
@brennan
Merge branch 'patrickshih/rebased-with-edge' into brennan/patrickshih…
cced776 
…/rebased-with-edge
@brennan
Update yarn.lock.
6990bfc
@brennan
Merge branch 'master' into brennan/patrickshih/rebased-with-edge
d5fd485
@brennan
Bump Optimizely version to 4.1.0.
d2c271f
@brennan brennan closed this Jul 25, 2022
@brennan brennan deleted the brennan/patrickshih/rebased-with-edge branch July 25, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brennan @nchilada @patrickshih-optimizely