Fix GA4 set bug #575
Merged
Fix GA4 set bug #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2021 15:56
brennan
reviewed
Mar 24, 2021
|
|
||
| // cookie_flags uses the `set` command | ||
| analytics.equal(window.ga4DataLayer[3][0]['cookie_flags'], 'SameSite=None;Secure') | ||
| analytics.equal(window.ga4DataLayer[3][0], 'set') |
Contributor
There was a problem hiding this comment.
Should we use a deepEqual here like the other updated tests!
Contributor
Author
There was a problem hiding this comment.
Yeah, that may be cleaner. I'll change before I merge!
Contributor
There was a problem hiding this comment.
Nice! Definitely a nit - but it does look nice this way! Thank you!
brennan
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request fixes a bug where GA4
setcommands were not being passed to gtag.js with the"set"string. This wasn't caught when loaded locally because GA will swallow the errors.Are there breaking changes in this PR?
N/A
Testing
"set"is passedAny background context you want to provide?
Is there parity with the server-side/android/iOS integration components (if applicable)?
Does this require a new integration setting? If so, please explain how the new setting works
Links to helpful docs and other external resources