-
Notifications
You must be signed in to change notification settings - Fork 141
Update Nielsen integration mappings and add new setting to Nielsen DCR #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @bsneed! I have made changes to our Nielsen DCR and DTVR web integrations, as requested by Nielsen. The changes made are outlined in the linked spreadsheet and JIRA. I've already made similar changes on iOS and Android so this is the last platform we need to tackle. I added some new unit tests and locally tested, and everything looks good. Would you or someone on the Libraries team be able to review and approve my changes? I'm newer to releasing web device-mode changes, but in the past we have pinned Fox's staging source(s) to a version of a.js with the changes so that they could test before we add to a release train. Is this possible? @brennan has helped with this in the past. thanks! |
|
Sources to pin (jotting this down for future reference):
|
|
hey @kdaswani, I'll take a look shortly |
|
Hi @pooyaj have you had a chance to take a look at this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one concern around the changes in the yarn.lock. otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After comparing the segment-events 2.2.0 vs. 2.2.5, the changes are non-breaking so this should be safe.
3c137b2 to
363ea95
Compare
…alytics.js-integrations into kiara/nielsen-changes
|
Added a small change to fix a bug with how By adding a check for if the setting exists, we move to the Confirmed all unit tests still pass: @pooyaj can you take a look? I think I'll need to update the SHA in the beta version for Nielsen DCR here: https://github.com/segmentio/analytics.js-private/pull/632/files. And then pin the new commit to the three dev sites previously pinned. Is that correct? Thanks! |
|
Updated mapping for |





What does this PR do?
This PR updates our Nielsen DCR and Nielsen DTVR integrations to meet Nielsen requirements. Changes requested by Nielsen are outlined in this spreadsheet.
Are there breaking changes in this PR?
No.
Testing
Nielsen DCR
Video Playback Interruptedtriggersstop(instead ofend):Video Playback Exitedtriggersstop:customSectionPropertypicks up setting from UI to map page property value tosectionif defined. In this example, I mappedtest_section_propertyin the UI as the Custom Section Property setting:If custom property is not included in page call, falls back on the page name:

Nielsen DTVR
Unit Tests - all passed, including new (for video playback exited) and changed tests. Removed two tests that are no longer relevant as Nielsen has requested we do not call

end.Local tests
Local testing passed. Firing
Video Content Completed,Video Playback Completed,Video Playback Exited,Video Playback Interrupted,Video Playback Paused,Video Playback Seek Started, andVideo Playback Buffer Startedforlinearstreams result in no calls to Nielsen as requested. Resuming playback viaVideo Playback Resumedreloads metadata and ID3 tags are picked up for any mapped events.All PRs must follow the process for change control as outlined in:
https://segment.atlassian.net/wiki/spaces/GRC/pages/453935287/Reinforcing+Change+Control
Any background context you want to provide?
Fox has been trying to get certified by Nielsen for a year+ now. In order to get certified using the Segment-Nielsen integrations, our integrations to meet Nielsen's requirements. This should be the last set of changes blocking certification.
Is there parity with the server-side/android/iOS integration components (if applicable)?
Yes. The same changes have already been made to iOS (published new versions) and Android (being tested by customer before publishing new versions):
Does this require a new integration setting? If so, please explain how the new setting works
Yes. The Nielsen DCR integration requires a new setting for
customSectionProperty. This setting is already live in prod (Partner Portal) as it is used in iOS and Android too. The setting allows a customer to choose which property on their page calls maps to the Nielsensectionfield. If nothing is set, we will fallback on the page name which is the existing behavior.Links to helpful docs and other external resources
See spreadsheet linked above.