Skip to content

Conversation

@pooyaj
Copy link
Contributor

@pooyaj pooyaj commented Jun 17, 2021

What does this PR do?
Adding the profitwell destination. Originally hosted here: https://github.com/ProfitWell/segment-dotjs but we need it internally to serve AJS 2.0.

Are there breaking changes in this PR?
No breaking change

Testing
Testing not required as this is a carbon copy of the third party version.

@pooyaj pooyaj requested a review from nettofarah June 17, 2021 23:49
@pooyaj
Copy link
Contributor Author

pooyaj commented Jun 17, 2021

@nettofarah any gotchas in importing these destinations? I just copied the code directly.

Copy link
Contributor

@nettofarah nettofarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pooyaj pooyaj merged commit a804b8c into master Jun 21, 2021
@pooyaj pooyaj deleted the pj/profitwell branch June 21, 2021 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants