update klaviyo integration to support exchange ID #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Klaviyo recently made an update to its web tracking. An
$exchange_idwas introduced which is an encrypted envelope containing identifiers. Segment's Klaviyo integration does not consider this identifier, and in the absence of other identifiers (like email and ID) is skippingtrackrequests.This PR allows the Segment/Klaviyo integration to recognize and pass along exchange IDs as they are encountered.
Are there breaking changes in this PR?
No, these changes are supplemental to existing behavior.
Testing
Testing completed successfully on stage via AJS 2.0
Test cases were added to existing coverage, all of which is passing.
Any background context you want to provide?
https://help.klaviyo.com/hc/en-us/articles/115005076767-Guide-to-Klaviyo-Web-Tracking#the-_kx-parameter5
Is there parity with the server-side/android/iOS integration components (if applicable)?
Unsure.
Does this require a new integration setting? If so, please explain how the new setting works
No.
Links to helpful docs and other external resources
https://help.klaviyo.com/hc/en-us/articles/115005076767-Guide-to-Klaviyo-Web-Tracking#the-_kx-parameter5