Skip to content

Conversation

@juliofarah
Copy link
Contributor

This PR is a copy of #626 .
I created this copy because I needed to bump a minor version on package.json and didn't want to block the PR because of this.

What does this PR do?

  • it has bug fixes where reset was getting called when userID is passed
  • alias method implemented

Are there breaking changes in this PR?

  • No

Any background context you want to provide?

  • We were expecting the reset() method to be available in integration and wrote the code accordingly. Now its causing unnecessary logout from our SDK on adding user IDs.

Is there parity with the server-side/android/iOS integration components (if applicable)?

  • Not applicable

Does this require a new integration setting? If so, please explain how the new setting works -

  • No

Links to helpful docs and other external resources

Why is this PR raised?

  • There was an issue raised by a customer which was causing unnecessary logouts on MoEngage side and thus bloating the user counts in MoEngage

Are there any docs surrounding the change?

What will the customer impact be as a result of the change?

  • The customer experience will improve when integrating MoEngage and Segment as we will no longer create multiple users on login.

What will the customer impact be if the change is not implemented?

  • The user count in MoEngage will bloat up when using Segment <> MoEngage integration and setting the user ID on identify.

Testing

  • Testing completed successfully

@juliofarah juliofarah changed the title Fix moengage Fix/moengage id reset handle Sep 28, 2021
@juliofarah
Copy link
Contributor Author

Testing with AJS 2:

Track:
image

Identify:
image

@juliofarah juliofarah merged commit ecef8eb into master Sep 28, 2021
@juliofarah juliofarah deleted the fix-moengage branch September 28, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants