-
Notifications
You must be signed in to change notification settings - Fork 141
Added support for Hotjar Events API. #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Hotjar Events API. #660
Conversation
bc0c117 to
e0a853d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliomalegria Thank you so much for the update and apologies for the delay in reviewing. This looks great, we'll merge it right away!
|
Merging into feature branch - will create new PR from feature branch to trigger CI. Edit: PR to trigger CI - #677 |
* Added support for Hotjar Events API. * Start passing properties() to the Event API * Updated tests to check track with/without properties Co-authored-by: julio.alegria <julio.alegria@hotjar.com> Co-authored-by: Ariel Silvestri <arielsilvestri0715@gmail.com> Co-authored-by: Julio M. Alegria <juliomalegria@users.noreply.github.com> Co-authored-by: julio.alegria <julio.alegria@hotjar.com> Co-authored-by: Ariel Silvestri <arielsilvestri0715@gmail.com>
What does this PR do?
This PR adds
tracksupport for Hotjar integration script (Hotjar Events API).Are there breaking changes in this PR?
No.
Testing
Testing completed successfully
Any background context you want to provide?
Hotjar now has an Events API. It will be beneficial for Segment and Hotjar users to be able to make use of it seamlessly.
Is there parity with the server-side/android/iOS integration components (if applicable)?
No
Does this require a new integration setting? If so, please explain how the new setting works
No
Links to helpful docs and other external resources
https://help.hotjar.com/hc/en-us/articles/4405109971095-Events-API-Reference