update all @segment/trample to same minimum version #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pooyaj
approved these changes
Sep 9, 2022
Contributor
pooyaj
left a comment
pooyaj
left a comment
There was a problem hiding this comment.
weird issue ... nice find 💥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
@segment/trampledependency to have the same minimum version across all integrations (currently just 2 - adobe analytics and kenshoo infinity).This is needed because the common vendor file that contains the dependencies of all integrations was only pulling in the older version of
@segment/trample. I'm not sure why it chose0.2.0instead of0.2.1since the latter met the version requirements for kenshoo, but this change resolves the issue.This is especially important for the adobe analytics integration which needs the
0.2.1update.Testing
Testing completed successfully by rebuilding the integrations and validating the new trample code exists in the vendor file.