This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Deprecate data attributes#51
Merged
nettofarah merged 3 commits into4.0.0from Oct 10, 2019
Merged
Conversation
nettofarah
added a commit
that referenced
this pull request
Oct 10, 2019
* Use hooks based API with container * Add new `closeBehavior` option to Consent Manager (#48) * Add option to define onCloseBehavior * Add option to subscribe to preference changes * Watch standalone build on dev * Add consent option to dataset * Document new Option * Initial Preferences override (#49) * Document props * Add option to provide custom initial consent * Change signature * Harden type * Swap write keys * Add CookieView to every story * Fix logic * Do not generate sourceMap * Bump size limit * Deprecate data attributes (#51) * Remove instructions from README * Deprecate dataset options * Simplify further * Expose preferences manager (#52) * Add changelog (#53) * Update version;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove support to
datasetattributes for the consent manager tag as it could potentially encourage customers to use features that don't have full compatibility with analytics.js