fix issue 28 #29
Merged
fix issue 28 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Go does some magic when converting from non-empty to empty interfaces, the casting of
*(*interface{})(p)for all interface types was not good enough.This PR addresses it by falling back to the reflect package for this specific case. I don't anticipate this having an impact on performance, non-empty interface types in JSON are rare because they can't really be unmarshaled, and the use of
reflect.NewAtand conversion of an interface tointerface{}doesn't add much overhead.I've added a test which was reproducing the bug and is now passing with the fix.