Making SearchInput width-aware #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rowno
reviewed
Feb 26, 2018
| paddingLeft={height} | ||
| appearance={appearance} | ||
| disable={disabled} | ||
| width={width} |
Contributor
There was a problem hiding this comment.
I think a better solution would be to add display="block" and width={null} to TextInput so it just stretches to fill the parent Box.
Contributor
Author
There was a problem hiding this comment.
I tested it, and it works if the parent Box has an explicit width.
If the parent's Box width is not set up, the TextInput wont expand to fill up space.
vadimdemedes
approved these changes
Feb 26, 2018
jeroenransijn
approved these changes
Feb 26, 2018
Contributor
|
Thanks @fforres for taking a look at this and fixing this! This was totally an annoying bug in Evergreen ❤️ |
This was referenced Feb 28, 2018
Merged
prateekgoel
pushed a commit
to prateekgoel/evergreen
that referenced
this pull request
Oct 26, 2018
* Adding width * Adding default width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo @Rowno @jeroenransijn
I came across a case where I needed to customize the width of the searchInput box.
Passing a 'width' prop to
SearchInputonly set the container's width and not the input, so hopefully this pr fixes that.Screenshot of storybook