-
Notifications
You must be signed in to change notification settings - Fork 836
feat(reader): allow consuming from multiple topics with a group #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
achille-roussel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks great 👍
We've decided to hold on merging until we have had the opportunity to run a production-scale test internally to build confidence that we are not introducing any regressions.
|
@dominicbarnes Thanks for your great work! We have started to use kafka-go in our products and we are in the process of shipping them to production and we need to consume from multiple topics by one group. As I can see that this is all set to be release is there anything I can do from my end to close this faster? If closing is not possible at this point can you please guild me with alternatives? |
|
@iAziz786 this change should be ready to go. We wanted to do a bit more production testing before we merge it to master to ensure we aren't introducing any regressions, but nothing else is blocking it. |
|
That's good news, although we have moved to confluent go library for now but will move back to kafka-go as soon as this PR is merged. |
|
We have same request to consume from multiple topics, can I ask when this will be merged? |
|
We'll proceed with merging this, we would definitely appreciate some feedback after some testing @iAziz786 ! |
This change allows the
Readerto consume from multiple topics when being used with a consumer group. To opt into this behavior, you supplyconfig.GroupTopicsinstead ofconfig.Topic, the default behavior and config is unchanged.The following open issues would be resolved by this change:
I've added test cases for several permutations of this new config:
TopicGroupTopics(one value)GroupTopics(multiple values)