feat(docs-evergreen): Re-skin button component#1259
Merged
imklau merged 10 commits intodocs-evergreenfrom Dec 1, 2020
Merged
Conversation
imklau
reviewed
Nov 27, 2020
imklau
reviewed
Nov 27, 2020
imklau
reviewed
Nov 27, 2020
| border-radius: 4px; | ||
| &--secondary { | ||
| background-color: color(secondary); | ||
| color: color(white); |
Contributor
There was a problem hiding this comment.
I think we can remove all duplicated white colors property since the default button-fill has it 🙈
Contributor
|
I'm not sure but maybe the hollow variant should have a white background 🤔 I forgot about the "Log in" button which is the same as the hollow one :(
|
Contributor
|
What's going on with this ' button--2
|
imklau
reviewed
Nov 27, 2020
1 task
|
Deploy preview for segment-docs-preview ready! Built with commit b19202f https://deploy-preview-1259--segment-docs-preview.netlify.app |
Contributor
Author
Neither I, removed |
imklau
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1234