-
Notifications
You must be signed in to change notification settings - Fork 396
Add CJ destination #8129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CJ destination #8129
Conversation
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this, @Amelia-Lane! I wasn't able to edit this myself, so I left some feedback to align this with our docs style guide.
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
Co-authored-by: rchinn1 <93161299+rchinn1@users.noreply.github.com>
|
Hi @rchinn1, I've made these changes - could you please take another look? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Amelia-Lane! We'll include this in our deploy this week.
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Proposed changes
Created new md for CJ destination based off template.
Merge timing