Skip to content

Conversation

@silesky
Copy link
Contributor

@silesky silesky commented Mar 30, 2023

test/repro here: https://github.com/silesky/segment-stale-reference/tree/main

The "minified" updated function is:

 analytics.factory = function (e) {
      return function () {
        if (window.analytics.initialized) {
          return window.analytics[e].apply(window.analytics, arguments);
        }
        var t = Array.prototype.slice.call(arguments);
        t.unshift(e);
        analytics.push(t);
        return analytics
      }
};

@silesky silesky changed the title make stale reference proof make stale reference proof [Do not merge] Mar 30, 2023
Copy link
Contributor

@pooyaj pooyaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

silesky and others added 2 commits March 30, 2023 20:09
Co-authored-by: Pooya Jaferian <pooya.j@gmail.com>
@silesky silesky force-pushed the feature/make-snippet-stale-reference-proof branch from d01dff9 to 6781b65 Compare March 31, 2023 01:42
@silesky silesky changed the title make stale reference proof [Do not merge] make stale reference-proof [Do not merge] Mar 31, 2023
@silesky silesky requested a review from chrisradek March 31, 2023 23:26
@silesky silesky changed the title make stale reference-proof [Do not merge] make stale reference-proof Mar 31, 2023
@silesky silesky changed the title make stale reference-proof make stale reference-proof [Do not merge] Mar 31, 2023
@silesky silesky changed the title make stale reference-proof [Do not merge] make stale reference-proof Apr 15, 2023
@silesky silesky merged commit 081faba into master Apr 15, 2023
@silesky silesky deleted the feature/make-snippet-stale-reference-proof branch April 15, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants