This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Duplicate service name across clusters bugfix#41
Merged
stephenmathieson merged 4 commits intosegmentio:masterfrom Jul 23, 2017
Merged
Duplicate service name across clusters bugfix#41stephenmathieson merged 4 commits intosegmentio:masterfrom
stephenmathieson merged 4 commits intosegmentio:masterfrom
Conversation
added 4 commits
July 21, 2017 08:53
Run both server and client at the same time with `npm run dev`
Fixes an issue where cluster was not being used as predicate for loading service info.
dankrieger
changed the title
stephenmathieson
approved these changes
Jul 23, 2017
Contributor
stephenmathieson
left a comment
stephenmathieson
left a comment
There was a problem hiding this comment.
LGTM! Thanks dude!
Rowno
added a commit
that referenced
this pull request
Oct 10, 2017
* origin/master: Duplicate service name across clusters bugfix (#41)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really dig the app, but came across an issue with identical service names across clusters. Added a fix for that by checking clusterArn in addition to service name when finding a service.
Additionally added the run commands to package.json so devs can use
npm run. Starting the dev environment now only requires runningnpm run devwhich will run both server and cilent at the same time. Updated the README.Also added some padding to the app so the content doesn't run right the edge of the window.