fix: don't print confirmation prompt when skip-confirm is set#260
Open
patsevanton wants to merge 1 commit intosegmentio:masterfrom
Open
fix: don't print confirmation prompt when skip-confirm is set#260patsevanton wants to merge 1 commit intosegmentio:masterfrom
patsevanton wants to merge 1 commit intosegmentio:masterfrom
Conversation
Move fmt.Printf() after the skip check in util.Confirm() so that the prompt text is not printed to stdout when --skip-confirm flag is used. This fixes the issue where Kubernetes Jobs would hang because the prompt output made it appear the process was waiting for input. Fixes segmentio#259
Author
|
work: |
Author
|
@dateutli @changgesi @pazhang-25 Please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fmt.Printf()after theskipcheck inutil.Confirm()so that the prompt text is not printed to stdout when--skip-confirmflag is used.applycompletes, because the"OK to continue? (yes/no)"text is no longer written to stdout in non-interactive environments.Changes
pkg/util/confirm.go: Moved thefmt.Printf("%s (yes/no) ", prompt)call to execute only whenskipisfalse, after the early return for the skip case.