replace innerRef with forwardRef #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's up with all the |
mshwery
changed the title
Contributor
Author
|
@akleiner2 honestly not sure where they came from! reverted that file. |
Contributor
Author
|
This will land as a breaking change |
Contributor
Author
|
Cutting an |
|
@mshwery is this good to take a stab at cutting over into |
Contributor
Author
|
@akleiner2 feel free to give it a spin! It should be available via |
mshwery
pushed a commit
that referenced
this pull request
Jul 28, 2020
* replace innerRef with forwardRef (#61) * enable safe hrefs by default (#63) * use separate sourcemaps and fix yarn size-limit * format file, remove comments from dist * lint --fix a few things * node 10.18+ * upgrade ts deps and use simpler polymorphic typing (#71) * v4.0.0-1 * update types again * export types * v4.0.0-2 * revert propsOf back * v4.0.0-3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches from
innerReftoReact.forwardRefsupport. Not 100% sure on the typing because we have to do some custom stuff to get the generic types to work right here...