Skip to content

Conversation

@mshwery
Copy link
Contributor

@mshwery mshwery commented May 23, 2020

Switch the default behavior of ui-box to enable safe hrefs.

@mshwery mshwery requested review from akleiner2 and colinlohner May 23, 2020 04:38
Copy link

@akleiner2 akleiner2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@colinlohner colinlohner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mshwery mshwery merged commit e679fa6 into v4 May 26, 2020
@mshwery mshwery deleted the v4-enable-safe-href branch May 26, 2020 17:57
mshwery pushed a commit that referenced this pull request Jul 28, 2020
* replace innerRef with forwardRef (#61)

* enable safe hrefs by default (#63)

* use separate sourcemaps and fix yarn size-limit

* format file, remove comments from dist

* lint --fix a few things

* node 10.18+

* upgrade ts deps and use simpler polymorphic typing (#71)

* v4.0.0-1

* update types again

* export types

* v4.0.0-2

* revert propsOf back

* v4.0.0-3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants