Skip to content

disallow pre-155 transactions#2306

Merged
codchen merged 2 commits intomainfrom
tony/disallow-unsafe-legacy
Aug 18, 2025
Merged

disallow pre-155 transactions#2306
codchen merged 2 commits intomainfrom
tony/disallow-unsafe-legacy

Conversation

@codchen
Copy link
Copy Markdown
Collaborator

@codchen codchen commented Aug 13, 2025

Describe your changes and provide context

unprotected transactions are vulnerable to replay attacks

Testing performed to validate your change

integration test

@codchen codchen force-pushed the tony/disallow-unsafe-legacy branch 2 times, most recently from f70f753 to d462577 Compare August 14, 2025 02:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.56%. Comparing base (1a20f68) to head (f63bc45).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/ante/preprocess.go 44.44% 3 Missing and 2 partials ⚠️
aclmapping/evm/mappings.go 0.00% 0 Missing and 1 partial ⚠️
app/app.go 0.00% 0 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (36.36%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
- Coverage   60.56%   60.56%   -0.01%     
==========================================
  Files         313      313              
  Lines       30758    30763       +5     
==========================================
+ Hits        18629    18632       +3     
- Misses      10832    10833       +1     
- Partials     1297     1298       +1     
Files with missing lines Coverage Δ
aclmapping/evm/mappings.go 89.07% <0.00%> (ø)
app/app.go 66.61% <0.00%> (ø)
x/evm/ante/preprocess.go 79.07% <44.44%> (-0.41%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/disallow-unsafe-legacy branch from d462577 to f63bc45 Compare August 18, 2025 03:43
@codchen codchen merged commit d356344 into main Aug 18, 2025
108 of 114 checks passed
@codchen codchen deleted the tony/disallow-unsafe-legacy branch August 18, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants