RPC fixes cherrypick from v6.1.11 #2388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
requested review from
philipsu522,
sei-will,
stevenlanders and
yzang2019
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| blockHeight := int64(len(ts.mockClient.txResults) + 1) | ||
| for i, block := range blocks { | ||
| height := blockHeight + int64(i) | ||
| blockTime := time.Now() |
Check warning
Code scanning / CodeQL
Calling the system time Warning test
codchen
force-pushed
the
tony/rpc-fixes
branch
3 times, most recently
from
0092a97 to
bf0745f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
==========================================
+ Coverage 60.44% 63.42% +2.98%
==========================================
Files 314 364 +50
Lines 31127 33532 +2405
==========================================
+ Hits 18815 21269 +2454
+ Misses 10993 10783 -210
- Partials 1319 1480 +161
🚀 New features to boost your workflow:
|
stevenlanders
requested changes
Sep 23, 2025
Contributor
stevenlanders
left a comment
stevenlanders
left a comment
There was a problem hiding this comment.
For code hygiene and safety, and given the area of modifications, I think we should either remove the skipped tests or ensure they work. What do you think?
codchen
force-pushed
the
tony/rpc-fixes
branch
3 times, most recently
from
4eec7d9 to
c4a7282
Compare
stevenlanders
approved these changes
Sep 24, 2025
codchen
force-pushed
the
tony/include-synthetic-log-in-eth
branch
from
c54d9e7 to
98b9061
Compare
codchen
force-pushed
the
tony/rpc-fixes
branch
from
c4a7282 to
0d1a99c
Compare
philipsu522
approved these changes
Sep 25, 2025
codchen
force-pushed
the
tony/rpc-fixes
branch
from
0d1a99c to
52db1cb
Compare
codchen
added a commit
that referenced
this pull request
Sep 25, 2025
* always include synthetic logs * more tests * RPC fixes cherrypick from v6.1.11 * fix block bloom & gas used * add tests and refactor tx.go * fix coverage flag * fix tests
codchen
added a commit
that referenced
this pull request
Sep 25, 2025
* Fix gas price mismatch in RPC responses (#2276) * Only Synthetic Logs for Sei Endpoints (#2268) * Only Synthetic Logs for Sei evmrpc * Update comment * lint * Update comment * lint * Upate to filter and keep evm log bloom * Update comment * Update filter * Add legacy fallback * Use Transient Receipts * Update integration tests * Update integration tests --------- Co-authored-by: Philip Su <philip.su.522@gmail.com> * Refactor `GetEvmTxIndex` (#2303) * [SEI-9891][SEI-9893] Fix input `transactionIndex` (#2302) * Add versioning to EVM params (#2297) * Add versioning to EVM params * add test * do not check version for latest height (#2311) * Fix ante failure check in RPC (#2343) Fixed ante failure check in RPC Co-authored-by: Philip Su <philip.su.522@gmail.com> * Skip txs failing ante when counting tx index for receipts (#2344) * Skip txs failing ante when counting tx index for receipts * fix tests * tmp * Use Current Block Context For Logs (#2333) * Use Current Block Context * Overwrite block number and hash in fetcher * Update to synthetic logs * fix unit tests --------- Co-authored-by: Jeremy Wei <jeremy.t.wei@gmail.com> Co-authored-by: Tony Chen <codchen03@gmail.com> * Exclude synthetic logs from receipts returned by eth_ (#2361) * Exclude synthetic logs from receipts returned by eth_ * fix integration tests * eth_gasPrice fixes (#2364) * gas price fix * remove unnecessary code to get block gas limit * go fmt * add coverage * remove unnecessary line * Estimate Gas Fix (#2374) * add estimate gas fix * fix lint * add test * update go mod * only use estimate if below gas limit * update go mod * fix * fix unnecessary logic * go mod update * update go mod * update geth * [CON-69] Fix block gas used (#2377) * always include synthetic logs in eth_ endpoints (#2371) * always include synthetic logs * adjust EvmLogBloom * more tests * fix conflicts * RPC fixes cherrypick from v6.1.11 (#2388) * always include synthetic logs * more tests * RPC fixes cherrypick from v6.1.11 * fix block bloom & gas used * add tests and refactor tx.go * fix coverage flag * fix tests * fix conflicts --------- Co-authored-by: Kartik Bhat <kartikbhatri@gmail.com> Co-authored-by: Philip Su <philip.su.522@gmail.com> Co-authored-by: pdrobnjak <pavle@tenderly.co> Co-authored-by: Jeremy Wei <jeremy.t.wei@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
cherrypick the following RPC changes:
Testing performed to validate your change