Do not resolve latest upon error
#2414
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Currently we are defaulting to
latestif an error happens, by doing this we are implicitly introducing side effects into user's query by returninglatestinstead of queried on error, a much better approach is to fail the request.As this change introduces an API break to
RPCContextProviderI've done an analysis of its usage across the codebase - it's only used in RPC routes (bothhttpandws) and in instantiations of EVM servers (bothhttpandws) therefore the newly introduced panic can either fail a request withor panic during server instantiation which will lead to failure to boot.
Testing performed to validate your change
Tested locally.