-
Notifications
You must be signed in to change notification settings - Fork 861
Fix sender discrepancy on RPC reads #2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2422 +/- ##
=========================================
+ Coverage 0 27.16% +27.16%
=========================================
Files 0 1465 +1465
Lines 0 144398 +144398
=========================================
+ Hits 0 39227 +39227
- Misses 0 101818 +101818
- Partials 0 3353 +3353
🚀 New features to boost your workflow:
|
codchen
approved these changes
Oct 3, 2025
philipsu522
approved these changes
Oct 3, 2025
stevenlanders
added a commit
that referenced
this pull request
Oct 3, 2025
- for reads: resolves signature using eip155 signer if chain ID is 0 (to handle older txs) - handles signature resolution for receipts vs. txs on reads - does not touch actual signature recovery for processing - unit tests
stevenlanders
added a commit
that referenced
this pull request
Oct 6, 2025
## Describe your changes and provide context - for reads: resolves signature using eip155 signer if chain ID is 0 (to handle older txs) - handles signature resolution for receipts vs. txs on reads - does not touch actual signature recovery for processing ## Testing performed to validate your change - unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change