Skip to content

Conversation

@stevenlanders
Copy link
Contributor

@stevenlanders stevenlanders commented Oct 1, 2025

Describe your changes and provide context

  • for reads: resolves signature using eip155 signer if chain ID is 0 (to handle older txs)
  • handles signature resolution for receipts vs. txs on reads
  • does not touch actual signature recovery for processing

Testing performed to validate your change

  • unit tests

@codecov
Copy link

codecov bot commented Oct 2, 2025

Codecov Report

❌ Patch coverage is 84.69388% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.16%. Comparing base (1c75665) to head (314f73c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
evmrpc/tx.go 54.16% 8 Missing and 3 partials ⚠️
evmrpc/rpcutils/sig.go 92.59% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main    #2422       +/-   ##
=========================================
+ Coverage      0   27.16%   +27.16%     
=========================================
  Files         0     1465     +1465     
  Lines         0   144398   +144398     
=========================================
+ Hits          0    39227    +39227     
- Misses        0   101818   +101818     
- Partials      0     3353     +3353     
Files with missing lines Coverage Δ
evmrpc/block.go 71.78% <100.00%> (ø)
evmrpc/filter.go 71.28% <100.00%> (ø)
evmrpc/simulate.go 71.86% <100.00%> (ø)
evmrpc/txpool.go 73.80% <100.00%> (ø)
evmrpc/utils.go 77.82% <100.00%> (ø)
evmrpc/rpcutils/sig.go 92.59% <92.59%> (ø)
evmrpc/tx.go 80.24% <54.16%> (ø)

... and 1458 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stevenlanders stevenlanders merged commit 5188d67 into main Oct 3, 2025
92 checks passed
@stevenlanders stevenlanders deleted the steven/fix-from-discrepancy-main branch October 3, 2025 17:51
stevenlanders added a commit that referenced this pull request Oct 3, 2025
- for reads: resolves signature using eip155 signer if chain ID is 0 (to
handle older txs)
- handles signature resolution for receipts vs. txs on reads
- does not touch actual signature recovery for processing

- unit tests
stevenlanders added a commit that referenced this pull request Oct 6, 2025
## Describe your changes and provide context
- for reads: resolves signature using eip155 signer if chain ID is 0 (to
handle older txs)
- handles signature resolution for receipts vs. txs on reads
- does not touch actual signature recovery for processing

## Testing performed to validate your change
- unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants