Skip to content

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Oct 16, 2025

sei-protocol/sei-tendermint#308 has accidentally changed the semantics of ParseAddressString from resolving the tcp address to parsing tcp address. As a side effect, support for DNS names in the config has been removed.

This PR reverts to the original semantics to support DNS names again. Also renamed the functions to better describe what they do.

@github-actions
Copy link

github-actions bot commented Oct 16, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 16, 2025, 11:24 AM

@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.62%. Comparing base (fdd0a6e) to head (5503f52).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/types/node_info.go 0.00% 7 Missing ⚠️
sei-tendermint/internal/p2p/transport.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (10.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (46.97%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2470       +/-   ##
===========================================
+ Coverage   39.63%   50.62%   +10.99%     
===========================================
  Files        1582     1592       +10     
  Lines      161700   162000      +300     
===========================================
+ Hits        64082    82010    +17928     
+ Misses      92766    73750    -19016     
- Partials     4852     6240     +1388     
Flag Coverage Δ
sei-chain 27.10% <0.00%> (-0.01%) ⬇️
sei-cosmos 51.95% <ø> (-0.01%) ⬇️
sei-tendermint 58.42% <33.33%> (?)
sei-wasmd 51.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/node/setup.go 69.02% <100.00%> (+69.02%) ⬆️
sei-tendermint/internal/p2p/transport.go 80.23% <0.00%> (+80.23%) ⬆️
sei-tendermint/types/node_info.go 0.00% <0.00%> (ø)

... and 182 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 merged commit 9c986af into main Oct 16, 2025
119 of 124 checks passed
@pompon0 pompon0 deleted the gprusak-parseaddr branch October 16, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants