-
Notifications
You must be signed in to change notification settings - Fork 861
Made tendermint reactors open channels in constructor #2487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-chain into gprusak-channel
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (53.71%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2487 +/- ##
==========================================
- Coverage 43.33% 43.33% -0.01%
==========================================
Files 1650 1650
Lines 139967 139993 +26
==========================================
+ Hits 60658 60662 +4
+ Misses 73975 73964 -11
- Partials 5334 5367 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
| // TODO: Evaluate if we need this to be synchronized via WaitGroup as to not | ||
| // leak the goroutine when stopping the reactor. | ||
| go r.peerStatsRoutine(ctx, peerUpdates) | ||
| go r.peerStatsRoutine(ctx) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| go r.processVoteCh(ctx) | ||
| go r.processVoteSetBitsCh(ctx) | ||
| go r.processPeerUpdates(ctx, peerUpdates, *r.channels) | ||
| go r.processPeerUpdates(ctx) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| go r.gossipDataRoutine(ctx, ps, chans.data) | ||
| go r.gossipVotesRoutine(ctx, ps, chans.vote) | ||
| go r.queryMaj23Routine(ctx, ps, chans.state) | ||
| go r.gossipDataRoutine(ctx, ps) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| go r.gossipVotesRoutine(ctx, ps, chans.vote) | ||
| go r.queryMaj23Routine(ctx, ps, chans.state) | ||
| go r.gossipDataRoutine(ctx, ps) | ||
| go r.gossipVotesRoutine(ctx, ps) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| go r.queryMaj23Routine(ctx, ps, chans.state) | ||
| go r.gossipDataRoutine(ctx, ps) | ||
| go r.gossipVotesRoutine(ctx, ps) | ||
| go r.queryMaj23Routine(ctx, ps) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
|
|
||
| func (r *Reactor) OnStart(ctx context.Context) error { | ||
| go r.processPeerUpdates(ctx, r.peerEvents(ctx)) | ||
| go r.processPeerUpdates(ctx) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| } | ||
| go r.processMempoolCh(ctx, r.channel) | ||
| go r.processPeerUpdates(ctx, r.peerEvents(ctx), r.channel) | ||
| go r.processMempoolCh(ctx) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
| go r.processMempoolCh(ctx, r.channel) | ||
| go r.processPeerUpdates(ctx, r.peerEvents(ctx), r.channel) | ||
| go r.processMempoolCh(ctx) | ||
| go r.processPeerUpdates(ctx) |
Check notice
Code scanning / CodeQL
Spawning a Go routine Note
15c1947 to
038dc21
Compare
356d8f7 to
2447b73
Compare
2447b73 to
5440b7f
Compare
Made tendermint reactors open channels in constructor, rather than expect the channels to be set externally. It is more manageable this way. Also moved SendError method from Channel to PeerManager.