Skip to content

Conversation

@pompon0
Copy link
Contributor

@pompon0 pompon0 commented Oct 29, 2025

Logger in sei-tendermint is weakly typed which causes panics if the call arguments don't have expected types.

In particular we had a couple of logging lines which passed non-string arguments were strings were expected.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 30, 2025, 11:10 AM

@pompon0 pompon0 requested review from pdrobnjak and udpatil October 29, 2025 16:05
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.12%. Comparing base (0eed7c3) to head (19df43d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/internal/evidence/pool.go 0.00% 1 Missing ⚠️
sei-tendermint/internal/p2p/router.go 0.00% 1 Missing ⚠️
sei-tendermint/rpc/jsonrpc/test/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2515      +/-   ##
==========================================
- Coverage   43.16%   43.12%   -0.04%     
==========================================
  Files        1583     1583              
  Lines      139151   139151              
==========================================
- Hits        60066    60015      -51     
- Misses      73642    73695      +53     
+ Partials     5443     5441       -2     
Flag Coverage Δ
sei-chain 31.30% <ø> (-0.02%) ⬇️
sei-cosmos 52.40% <ø> (ø)
sei-db 47.62% <ø> (+0.03%) ⬆️
sei-tendermint 47.64% <0.00%> (-0.14%) ⬇️
sei-wasmd 46.39% <ø> (+0.02%) ⬆️
sei-wasmvm 40.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/evidence/pool.go 69.37% <0.00%> (ø)
sei-tendermint/internal/p2p/router.go 74.89% <0.00%> (ø)
sei-tendermint/rpc/jsonrpc/test/main.go 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge (squash) October 29, 2025 16:06
@pompon0 pompon0 requested a review from codchen October 30, 2025 11:10
@pompon0 pompon0 merged commit cfc1b0d into main Oct 30, 2025
41 of 47 checks passed
@pompon0 pompon0 deleted the gprusak-logger branch October 30, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants