Skip to content

Conversation

@udpatil
Copy link
Collaborator

@udpatil udpatil commented Oct 30, 2025

Describe your changes and provide context

This does a minor refactor to tracing utils to simplify them, and manage block spans on the parent function

Testing performed to validate your change

Unit tests

@github-actions
Copy link

github-actions bot commented Oct 30, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedOct 30, 2025, 8:17 PM

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.14%. Comparing base (30f5ed6) to head (d446dbe).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/abci.go 71.42% 2 Missing ⚠️

❌ Your project status has failed because the head coverage (47.73%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2520   +/-   ##
=======================================
  Coverage   43.14%   43.14%           
=======================================
  Files        1583     1583           
  Lines      139151   139129   -22     
=======================================
- Hits        60036    60028    -8     
+ Misses      73671    73657   -14     
  Partials     5444     5444           
Flag Coverage Δ
sei-chain 31.32% <81.81%> (+0.01%) ⬆️
sei-cosmos 52.37% <100.00%> (-0.04%) ⬇️
sei-db 47.58% <ø> (ø)
sei-tendermint 47.72% <ø> (+<0.01%) ⬆️
sei-wasmd 46.37% <ø> (-0.01%) ⬇️
sei-wasmvm 40.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 72.50% <100.00%> (+0.25%) ⬆️
sei-cosmos/utils/tracing/tracer.go 90.24% <100.00%> (-3.51%) ⬇️
app/abci.go 60.00% <71.42%> (-2.80%) ⬇️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@udpatil udpatil force-pushed the uday/refactor-tracing branch from eafc962 to d446dbe Compare October 30, 2025 20:14
@udpatil udpatil enabled auto-merge (squash) October 30, 2025 20:14
@udpatil udpatil disabled auto-merge October 30, 2025 20:15
@udpatil udpatil merged commit d2c0b2a into main Oct 30, 2025
44 of 47 checks passed
@udpatil udpatil deleted the uday/refactor-tracing branch October 30, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants