Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Oct 31, 2025

Describe your changes and provide context

Previously, BeginBlock follows a very involved call path:

SeiApp->BaseApp->SeiApp->ModuleManager->Modules->keepers

This PR simplifies BeginBlock to be SeiApp->keepers

Testing performed to validate your change

no functional change

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 4, 2025, 3:24 AM

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 31.06061% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.19%. Comparing base (804cde6) to head (178c90f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/keeper/abci.go 0.00% 26 Missing ⚠️
x/epoch/keeper/abci.go 0.00% 21 Missing ⚠️
app/legacyabci/begin_block.go 0.00% 11 Missing ⚠️
app/abci.go 53.33% 4 Missing and 3 partials ⚠️
sei-cosmos/baseapp/baseapp.go 12.50% 7 Missing ⚠️
sei-wasmd/x/wasm/ibctesting/chain.go 0.00% 6 Missing ⚠️
sei-cosmos/x/distribution/abci.go 0.00% 4 Missing ⚠️
sei-cosmos/x/evidence/abci.go 0.00% 3 Missing ⚠️
app/app.go 85.71% 2 Missing ⚠️
sei-cosmos/baseapp/abci.go 66.66% 2 Missing ⚠️
... and 2 more

❌ Your patch status has failed because the patch coverage (31.06%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (48.06%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
- Coverage   43.21%   43.19%   -0.02%     
==========================================
  Files        1579     1582       +3     
  Lines      138492   138442      -50     
==========================================
- Hits        59843    59806      -37     
+ Misses      73211    73202       -9     
+ Partials     5438     5434       -4     
Flag Coverage Δ
sei-chain 31.22% <31.00%> (-0.08%) ⬇️
sei-cosmos 52.51% <36.00%> (-0.05%) ⬇️
sei-db 47.60% <ø> (ø)
sei-tendermint 48.05% <ø> (+0.10%) ⬆️
sei-wasmd 46.25% <5.88%> (-0.10%) ⬇️
sei-wasmvm 40.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
evmrpc/send.go 45.65% <100.00%> (ø)
evmrpc/server.go 91.09% <100.00%> (ø)
evmrpc/simulate.go 70.05% <100.00%> (+0.07%) ⬆️
evmrpc/tracers.go 44.32% <100.00%> (ø)
sei-cosmos/baseapp/options.go 46.38% <ø> (-0.68%) ⬇️
sei-cosmos/types/module/module.go 54.76% <ø> (-2.33%) ⬇️
sei-cosmos/x/accesscontrol/module.go 0.00% <ø> (ø)
sei-cosmos/x/authz/module/module.go 0.00% <ø> (ø)
sei-cosmos/x/capability/module.go 48.00% <ø> (-2.95%) ⬇️
sei-cosmos/x/distribution/module.go 55.38% <ø> (+1.65%) ⬆️
... and 24 more

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@codchen codchen force-pushed the tony/streamline-abci branch 3 times, most recently from 5e3e8bf to 6bc167c Compare November 3, 2025 13:03
Copy link
Collaborator

@udpatil udpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question regarding capability BeginBlocker

func (am AppModule) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) {
defer telemetry.ModuleMeasureSince(types.ModuleName, time.Now(), telemetry.MetricKeyBeginBlocker)

am.keeper.InitMemStore(ctx)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this not previously calling capability's BeginBlocker function which also just calls the InitMemStore?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not quite sure - could just be a refactor oversight from cosmos-sdk

@codchen codchen force-pushed the tony/streamline-abci branch from 6bc167c to 178c90f Compare November 4, 2025 03:24
@codchen codchen merged commit 0aaaa6f into main Nov 5, 2025
38 of 41 checks passed
@codchen codchen deleted the tony/streamline-abci branch November 5, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants