-
Notifications
You must be signed in to change notification settings - Fork 861
Migrate transaction embedding proto types to Go types #2533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2533 +/- ##
==========================================
+ Coverage 43.34% 43.35% +0.01%
==========================================
Files 1576 1576
Lines 137822 137816 -6
==========================================
+ Hits 59735 59754 +19
+ Misses 72651 72640 -11
+ Partials 5436 5422 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
9c49d83 to
4073381
Compare
05d397a to
45ab9f0
Compare
RequestCheckTx from proto to Go type| RequestDeliverTx deliver_tx = 21; | ||
| RequestEndBlock end_block = 22; | ||
| RequestLoadLatest load_latest = 23; | ||
| RequestGetTxPriorityHint get_tx_priority_hint = 24; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reserve ids and names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe your changes and provide context
1st step as described in description of #2534.
Couple of points:
TxResultas it is an actual wire type, it is not only used on the artificial ABCI boundary but as a storage wire type as well: [1.] [2.]TxRecordas it is embedded inResponsePrepareProposalthis will be done in a separate PR.Testing performed to validate your change