Skip to content

Conversation

@pdrobnjak
Copy link
Contributor

@pdrobnjak pdrobnjak commented Nov 5, 2025

Describe your changes and provide context

1st step as described in description of #2534.

Couple of points:

  • We have not entirely removed TxResult as it is an actual wire type, it is not only used on the artificial ABCI boundary but as a storage wire type as well: [1.] [2.]
  • We have not yet tackled TxRecord as it is embedded in ResponsePrepareProposal this will be done in a separate PR.

Testing performed to validate your change

@pdrobnjak pdrobnjak self-assigned this Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 7, 2025, 3:03 PM

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 40.00000% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.35%. Comparing base (2d58dad) to head (36101cd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dermint/internal/state/indexer/mocks/event_sink.go 0.00% 12 Missing ⚠️
sei-tendermint/internal/state/mocks/event_sink.go 0.00% 10 Missing ⚠️
sei-tendermint/abci/client/mocks/client.go 0.00% 8 Missing ⚠️
sei-tendermint/abci/types/mocks/application.go 0.00% 8 Missing ⚠️
...-tendermint/internal/state/indexer/tx/null/null.go 0.00% 4 Missing ⚠️
sei-cosmos/baseapp/abci.go 50.00% 3 Missing ⚠️
...endermint/internal/proxy/mocks/app_conn_mempool.go 0.00% 3 Missing ⚠️
sei-tendermint/abci/types/application.go 0.00% 2 Missing ⚠️
sei-tendermint/internal/proxy/client.go 0.00% 2 Missing ⚠️
sei-tendermint/rpc/client/mock/abci.go 33.33% 2 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2533      +/-   ##
==========================================
+ Coverage   43.34%   43.35%   +0.01%     
==========================================
  Files        1576     1576              
  Lines      137822   137816       -6     
==========================================
+ Hits        59735    59754      +19     
+ Misses      72651    72640      -11     
+ Partials     5436     5422      -14     
Flag Coverage Δ
sei-chain 31.23% <66.66%> (-0.02%) ⬇️
sei-cosmos 52.55% <66.66%> (-0.01%) ⬇️
sei-db 47.60% <ø> (ø)
sei-tendermint 48.71% <35.29%> (+0.07%) ⬆️
sei-wasmd 46.27% <ø> (+0.02%) ⬆️
sei-wasmvm 40.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 73.30% <100.00%> (ø)
sei-cosmos/server/mock/app.go 78.37% <100.00%> (ø)
sei-cosmos/tasks/scheduler.go 92.90% <100.00%> (-0.71%) ⬇️
sei-cosmos/x/genutil/gentx.go 75.92% <100.00%> (ø)
sei-tendermint/abci/types/messages.go 7.21% <ø> (+0.42%) ⬆️
sei-tendermint/abci/types/types.go 21.34% <ø> (ø)
sei-tendermint/internal/state/execution.go 61.47% <100.00%> (ø)
sei-tendermint/internal/state/indexer/indexer.go 100.00% <100.00%> (ø)
...ndermint/internal/state/indexer/indexer_service.go 78.26% <100.00%> (ø)
...ei-tendermint/internal/state/indexer/sink/kv/kv.go 100.00% <100.00%> (ø)
... and 18 more

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdrobnjak pdrobnjak force-pushed the pd/migrate-request-check-tx-from-proto branch from 9c49d83 to 4073381 Compare November 5, 2025 10:49
@pdrobnjak pdrobnjak changed the base branch from pd/remove-grpc-socket-abci-client to pd/remove-abci-socket-grpc-functionality November 5, 2025 10:51
@pdrobnjak pdrobnjak marked this pull request as ready for review November 5, 2025 10:51
@pdrobnjak pdrobnjak force-pushed the pd/migrate-request-check-tx-from-proto branch from 05d397a to 45ab9f0 Compare November 5, 2025 11:58
@pdrobnjak pdrobnjak changed the title Migrate RequestCheckTx from proto to Go type Migrate transaction embedding proto types to Go types Nov 5, 2025
@pompon0 pompon0 requested review from pompon0 and sei-will November 5, 2025 14:33
RequestDeliverTx deliver_tx = 21;
RequestEndBlock end_block = 22;
RequestLoadLatest load_latest = 23;
RequestGetTxPriorityHint get_tx_priority_hint = 24;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reserve ids and names

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from pd/remove-abci-socket-grpc-functionality to main November 5, 2025 22:25
@pdrobnjak pdrobnjak enabled auto-merge (squash) November 5, 2025 22:34
@pdrobnjak pdrobnjak merged commit fe95a1f into main Nov 10, 2025
50 of 55 checks passed
@pdrobnjak pdrobnjak deleted the pd/migrate-request-check-tx-from-proto branch November 10, 2025 11:13
pompon0 added a commit that referenced this pull request Nov 12, 2025
pompon0 added a commit that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants