[giga] honor configured sstore gas values#2753
Conversation
…tocol/sei-chain into steven/add-giga-integration-test
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2753 +/- ##
==========================================
+ Coverage 57.00% 57.02% +0.01%
==========================================
Files 2004 2004
Lines 164603 164629 +26
==========================================
+ Hits 93838 93884 +46
+ Misses 62560 62541 -19
+ Partials 8205 8204 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
giga/executor/executor.go
Outdated
| if chainConfig.SeiSstoreSetGasEIP2200 != nil { | ||
| seiSstoreGas = *chainConfig.SeiSstoreSetGasEIP2200 | ||
| } | ||
| hostContext := internal.NewHostContext(evmoneVM, evm, seiSstoreGas) |
There was a problem hiding this comment.
Rather than passing the SSTORE into HostContext which requires to change the constructor, would it be easier to just add a function within HostContext to get the SStoreGas from chainConfig.SeiSstoreSetGasEIP2200 directly?
There was a problem hiding this comment.
I gave it some thought - i'm thinking there will likely be other things like this, so i adjusted the constructor to accept a HostContextConfig which will pre-render a gas sstore delta, avoid the pointer dereferences for SeiSstoreSetGasEIP2200 per tx sstore.
Describe your changes and provide context
Testing performed to validate your change