Support query latest state when SS disabled#2762
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2762 +/- ##
==========================================
- Coverage 57.01% 56.33% -0.69%
==========================================
Files 2004 2000 -4
Lines 164629 164036 -593
==========================================
- Hits 93869 92404 -1465
- Misses 62557 63542 +985
+ Partials 8203 8090 -113
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+250
to
+254
| for k, store := range rs.ckvStores { | ||
| if store.GetStoreType() != types.StoreTypeIAVL { | ||
| stores[k] = store | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
philipsu522
approved these changes
Jan 26, 2026
masih
approved these changes
Jan 26, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
## Describe your changes and provide context In previous PR, we removed completely to serve any historical query from SC, because that could cause data inconsistency issues (SC data is not in sync with SS) However that introduced a bug for validator nodes, since validator nodes have SS disabled, and it still need to be able to serve query with height=latestHeight This PR fixed both issues by adding the SC back, but only serve from SC when SS is disabled to keep the data still consistent for RPC node. ## Testing performed to validate your change Added unit test (cherry picked from commit cfd3327)
|
Successfully created backport PR for |
cursor bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
…abled Co-authored-by: yiren <yiren@seinetwork.io>
arajasek
pushed a commit
that referenced
this pull request
Jan 27, 2026
## Describe your changes and provide context In previous PR, we removed completely to serve any historical query from SC, because that could cause data inconsistency issues (SC data is not in sync with SS) However that introduced a bug for validator nodes, since validator nodes have SS disabled, and it still need to be able to serve query with height=latestHeight This PR fixed both issues by adding the SC back, but only serve from SC when SS is disabled to keep the data still consistent for RPC node. ## Testing performed to validate your change Added unit test
yzang2019
added a commit
that referenced
this pull request
Feb 25, 2026
In previous PR, we removed completely to serve any historical query from SC, because that could cause data inconsistency issues (SC data is not in sync with SS) However that introduced a bug for validator nodes, since validator nodes have SS disabled, and it still need to be able to serve query with height=latestHeight This PR fixed both issues by adding the SC back, but only serve from SC when SS is disabled to keep the data still consistent for RPC node. Added unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
In previous PR, we removed completely to serve any historical query from SC, because that could cause data inconsistency issues (SC data is not in sync with SS)
However that introduced a bug for validator nodes, since validator nodes have SS disabled, and it still need to be able to serve query with height=latestHeight
This PR fixed both issues by adding the SC back, but only serve from SC when SS is disabled to keep the data still consistent for RPC node.
Testing performed to validate your change
Added unit test