Skip to content

Add features & knobs to benchmark.sh#2770

Merged
codchen merged 1 commit intomainfrom
tony/benchmark
Jan 27, 2026
Merged

Add features & knobs to benchmark.sh#2770
codchen merged 1 commit intomainfrom
tony/benchmark

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Jan 27, 2026

Describe your changes and provide context

Add finer-grained metrics that track commit latency and execution latency, which excludes time spent on the tendermint side.
Also added a flag to turn off tx indexer and a flag to specify block size.

Testing performed to validate your change

./scripts/benchmark.sh

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 27, 2026, 3:31 PM

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 42.62295% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.91%. Comparing base (53b52ef) to head (291c667).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/benchmark.go 44.23% 26 Missing and 3 partials ⚠️
app/app.go 0.00% 2 Missing and 2 partials ⚠️
app/abci.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2770   +/-   ##
=======================================
  Coverage   56.91%   56.91%           
=======================================
  Files        2004     2004           
  Lines      164649   164703   +54     
=======================================
+ Hits        93705    93741   +36     
- Misses      62730    62739    +9     
- Partials     8214     8223    +9     
Flag Coverage Δ
sei-chain 41.74% <42.62%> (+<0.01%) ⬆️
sei-cosmos 48.13% <ø> (+<0.01%) ⬆️
sei-db 68.72% <ø> (ø)
sei-tendermint 58.64% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/abci.go 65.64% <60.00%> (-0.50%) ⬇️
app/app.go 74.26% <0.00%> (-0.26%) ⬇️
app/benchmark.go 73.84% <44.23%> (-11.29%) ⬇️

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

_, span := app.GetBaseApp().TracingInfo.StartWithContext("Commit", ctx)
defer span.End()
return app.BaseApp.Commit(ctx)
start := time.Now()

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
func (l *benchmarkLogger) StartBlockProcessing() {
l.mx.Lock()
defer l.mx.Unlock()
l.blockProcessStartTime = time.Now()

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
@codchen codchen enabled auto-merge (squash) January 27, 2026 15:30
@codchen codchen merged commit d2b43d3 into main Jan 27, 2026
42 of 43 checks passed
@codchen codchen deleted the tony/benchmark branch January 27, 2026 15:52
arajasek pushed a commit that referenced this pull request Jan 27, 2026
## Describe your changes and provide context
Add finer-grained metrics that track commit latency and execution
latency, which excludes time spent on the tendermint side.
Also added a flag to turn off tx indexer and a flag to specify block
size.

## Testing performed to validate your change
./scripts/benchmark.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants